Fix: Add safety check to hwmon read #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dswarbrick
reviewed
Sep 26, 2024
SuperQ
force-pushed
the
superq/hwmon_safe_read
branch
from
3ed0886
to
c9ad416
Compare
|
I think it would be helpful to include the value of n in the error message, because "failed to read file: foo" is pretty generic and vague. Either include the specific value of n, or clarify that the reason for failure is that the read returned a negative count - otherwise this will just get lost in the noise when it (hopefully rarely) fails. |
Avoid panic for accessing slice out of range in hwmon. Fixes: #3108 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
superq/hwmon_safe_read
branch
from
c9ad416
to
94fb1e4
Compare
roidelapluie
approved these changes
Sep 30, 2024
discordianfish
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid panic for accessing slice out of range in hwmon.
Fixes: #3108